-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: safe ecc_sum and tests #244
Conversation
Lint test is not passing (fix clippy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements!
Added a comment around into_strict
and also we can rename the existing sum
to unsafe_sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small unnecessary constraint I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there is a build issue with clap that I will try to resolve.
After axiom-crypto/halo2-lib#244 the `EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming to still use the `sum_unsafe` function so that snark verifier circuits do not change.
* chore: keep old behavior of `EccInstructions::sum_with_const` After axiom-crypto/halo2-lib#244 the `EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming to still use the `sum_unsafe` function so that snark verifier circuits do not change. * chore: fix clap version to prevent rust version issues * ci: install `svm-rs` with its `Cargo.lock` (#48) * chore: use solc-select instead of svm to avoid rust version issues --------- Co-authored-by: Han <[email protected]>
Wrote a safe version of sum that allows summands to be points at infinity and allows output to be point at infinity