Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Breaks/Conflicts/Replaces to debian control #79

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

foosel
Copy link
Contributor

@foosel foosel commented Jun 29, 2023

As discussed on Discord a while ago, adding Breaks/Conflicts/Replaces entries against camera-streamer (<< 0.2) allows for a smooth migration from the camera-streamer package built for OctoPi to camera-streamer-raspi, through a transitional camera-streamer version 0.2 on OctoPi's side.

An upgrade of camera-streamer from OctoPrint's apt repo will pull in an updated transitional camera-streamer package version 0.2 that depends on camera-streamer-raspi. For that to install flawlessly in all cases, it needs to be installed before the camera-streamer-raspi dependency
(as some files between that and the former camera-streamer package overlap). By declaring Breaks/Conflicts/Replaces relationships on camera-streamer-raspi this is ensured.

I've manually adjusted camera-streamer-raspi and created a version 0.2.1~bullseye-1 to test this on a private apt repo and in all my test scenarios upgrades work with these changes:

  • apt upgrade on a system that already has camera-streamer 0.1 pulls in the transitional package camera-streamer 0.2, which depends on camera-streamer-raspi, so that gets installed as well. apt does the install order the correct way only with the the additions in this PR
  • apt install camera-streamer-raspi on a system that already has camera-streamer 0.1 upgrades both camera-streamer to the transitional 0.2 and installs camera-streamer-raspi
  • apt install camera-streamer-raspi on a system that does NOT already have camera-streamer installed (so, OctoPi-UpToDate builds with the new camera stack going forward) only install camera-streamer-raspi

As discussed on Discord a while ago, adding
Breaks/Conflicts/Replaces entries against
camera-streamer (<< 0.2) allows for a smooth
migration from the camera-streamer package
built for OctoPi to camera-streamer-raspi, through
a transitional camera-streamer version 0.2 on
OctoPi's side.

An upgrade of camera-streamer from OctoPrint's
apt repo will pull in an updated transitional
camera-streamer package version 0.2 that depends
on camera-streamer-raspi. For that to install
flawlessly in all cases, it needs to be installed
*before* the camera-streamer-raspi dependency
(as some files between that and the former
camera-streamer package overlap). By
declaring Breaks/Conflicts/Replaces relationships
on camera-streamer-raspi this is ensured.
@ayufan ayufan merged commit f1966ab into ayufan:main Jul 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants