-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix txContext auto-cancellation of context (#4012)
Currently we auto cancel the context when the transaction is committed, which means any operation using that context can fail if it depends on the context's done state. This is causing flakiness in `TestBeginMultipleTransactions_Sequential` test in windows as the second transaction is created from the previous context, which will also be cancelled and rolled-back when the first one is committed and then cancelled. This PR fixes the issue by no longer cancelling the context of tx commit or rollback
- Loading branch information
Showing
2 changed files
with
28 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters