Webui settings #3075
Merged
Webui settings #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etail. Eventually available at HOST:POST/JobID
It's much easier to develop the UI using `npm run start` as changes are live-reloaded, compared with doing a whole rebuild and restart of Bacalhau. By default the index page contains Go template tags that Bacalhau will replace. Although the API client already ignores blank strings, we still have to cope with the Go template tags being present and ignore them.
- Rounded edges on rows - No internal borders - Fuzzy outline
- Sidebar now uses Bacalhau colour scheme and gradient from bacalhau.org - Sidebar buttons are now visible even when the sidebar is collapsed - Now use a landscape SVG logo instead of a stacked PNG - Settings button now at the bottom as per design - Unify transition times across all sidebar expands/collapses
simonwo
approved these changes
Dec 10, 2023
Comment on lines
+13
to
+21
| // Nodes Table | ||
| showNodeId?: boolean; | ||
| showNodeName?: boolean; | ||
| showNodeType?: boolean; | ||
| showEnv?: boolean; | ||
| showInputs?: boolean; | ||
| showOutputs?: boolean; | ||
| showVersion?: boolean; | ||
| showAction?: boolean; |
There was a problem hiding this comment.
We added customisable columns so that we could get more node details available in the table. Currently we're missing labels and capacity. Could you (add a new ticket to) add those in plz?
Comment on lines
+31
to
+39
| const jobsOptions: { label: string; key: keyof TableSettings }[] = [ | ||
| { label: "Job ID", key: "showJobId" }, | ||
| { label: "Name", key: "showJobName" }, | ||
| { label: "Created", key: "showCreated" }, | ||
| { label: "Program", key: "showProgram" }, | ||
| { label: "Job Type", key: "showJobType" }, | ||
| { label: "Label", key: "showLabel" }, | ||
| { label: "Status", key: "showStatus" }, | ||
| ]; |
There was a problem hiding this comment.
Can we use a similar technique to avoid hard-coding the TableSettingsContext i.e. not have to list each config as a separate variable?
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.