Remove building Bacalhau as part of Docker image build #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossjones
reviewed
Dec 12, 2023
| @@ -192,7 +192,7 @@ $(WEB_INSTALL_GUARD): webui/package.json | |||
| cd webui && npm install | |||
|
|
|||
| export GENERATE_SOURCEMAP := false | |||
| $(WEB_BUILD_FILES): $(WEB_SRC_FILES) $(WEB_INSTALL_GUARD) | |||
| ${WEB_BUILD_FILES} &: $(WEB_SRC_FILES) $(WEB_INSTALL_GUARD) | |||
There was a problem hiding this comment.
Yeah, I thought make did this by default, but it turns out it doesn't! TIL!
rossjones
approved these changes
Dec 12, 2023
This meant that our new Web UI build steps were not being picked up. This is not really necessary as we can just reuse the output that was created from our CI build step, rather than the rigmarole of trying to capture the right files and recreate the build process within the Dockerfile. This change also means we can build the docker image on PRs as well, to check that it works. There are some other refactors here – we now build and test as separate jobs so that we don't need to wait for tests to pass before pushing binaries to a release, and also generate all of our binaries from a single cross-compiling step (because we don't use CGO and hence can compile for all platforms from anywhere).
simonwo
force-pushed
the
fix-docker-build
branch
from
1dd52b4
to
6c34bc1
Compare
frrist
reviewed
Jan 15, 2024
| BINARY_PATH = bin/${GOOS}_${GOARCH}${GOARM}/${BINARY_NAME} | ||
| BINARY_PATH = bin/${GOOS}/${GOARCH}${GOARM}/${BINARY_NAME} |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This meant that our new Web UI build steps were not being picked up. This is not really necessary as we can just reuse the output that was created from our CI build step, rather than the rigmarole of trying to capture the right files and recreate the build process within the Dockerfile.
This change also means we can build the docker image on PRs as well, to check that it works.
There are some other refactors here – we now build and test as separate jobs so that we don't need to wait for tests to pass before pushing binaries to a release, and also generate all of our binaries from a single cross-compiling step (because we don't use CGO and hence can compile for all platforms from anywhere).
As a result of this refactor, the build time in CI is reduced from 17m to 14m... every little helps, I guess.