Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migate scenario tests to models pacakge #4139

Merged
merged 2 commits into from
Jun 27, 2024
Merged

refactor: migate scenario tests to models pacakge #4139

merged 2 commits into from
Jun 27, 2024

Conversation

frrist
Copy link
Member

@frrist frrist commented Jun 25, 2024 •
edited
Loading

closes #4140
part of #3832

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 25, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frrist frrist force-pushed the frrist/tests/update-scenarios-models branch from b42319a to 669cc99 Compare June 25, 2024 21:48
@frrist frrist marked this pull request as ready for review June 25, 2024 22:08
@frrist frrist force-pushed the frrist/tests/update-scenarios-models branch from 8b6af33 to ea2792f Compare June 25, 2024 22:10
@frrist frrist changed the title Frrist/tests/update scenarios models refactor: migate scenario tests to models pacakge Jun 25, 2024
@frrist frrist requested a review from wdbaruni June 25, 2024 22:17
@frrist frrist self-assigned this Jun 25, 2024
wdbaruni
wdbaruni reviewed Jun 26, 2024
View reviewed changes
pkg/node/node.go Show resolved Hide resolved
pkg/publicapi/apimodels/job.go Outdated Show resolved Hide resolved
pkg/test/compute/resourcelimits_test.go Outdated Show resolved Hide resolved
pkg/test/compute/resourcelimits_test.go Outdated Show resolved Hide resolved
pkg/test/devstack/concurrency_test.go Outdated
testCase := scenario.WasmHelloWorld(suite.T())
testCase.Stack = &scenario.StackConfig{
DevStackOptions: &devstack.DevStackOptions{
NumberOfHybridNodes: 1,
NumberOfComputeOnlyNodes: 2,
},
}
testCase.Deal = model.Deal{Concurrency: 2}
testCase.Job.Count = 2
testCase.Job.Task().Publisher = publisher_local.NewSpecConfig()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we need to set a publisher?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because this tests expects the results of the job to be downloaded and checked, and a publisher is required to do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified this slightly such that the testCase being used contains a publisher already

pkg/test/devstack/target_all_test.go Outdated Show resolved Hide resolved
pkg/test/executor/test_runner.go Outdated Show resolved Hide resolved
pkg/test/executor/test_runner.go Outdated
Comment on lines 90 to 91
// TODO(forrest) [fixme]: if we are allocating resources based on name, probably need more randomness
execution.AllocateResources(job.Task().Name, models.Resources{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task name but within job. if we randomize job ids, then these can be fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test case the jobID is random. But Task.Name doesn't take into account the job ID - its a field users provide. I guess if the mapping of execution to task is 1-1 then we need not worry.

pkg/test/executor/test_runner.go Show resolved Hide resolved
pkg/test/executor/test_runner.go Show resolved Hide resolved
@wdbaruni wdbaruni mentioned this pull request Jun 27, 2024
Closed
@wdbaruni wdbaruni merged commit a6a3103 into main Jun 27, 2024
10 of 12 checks passed
@wdbaruni wdbaruni deleted the frrist/tests/update-scenarios-models branch June 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdbaruni wdbaruni wdbaruni approved these changes

Assignees

@frrist frrist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate scenario tests to models package
2 participants
@frrist @wdbaruni