review: propagate context

bakito · May 12, 2023 · a9a37db · a9a37db
1 parent 6d51f35
commit a9a37db
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/pkg/handler/validate.go b/pkg/handler/validate.go
@@ -8,7 +8,7 @@ import (
 )
 
 func (h *Handler) Validate(c *gin.Context) {
-	err := h.sealer.Validate(c.Request.Body)
+	err := h.sealer.Validate(c, c.Request.Body)
 	if err != nil {
 		log.Printf("Error in %s: %v\n", Sanitize(c.Request.URL.Path), err)
 		c.Data(http.StatusBadRequest, "text/plain", []byte(err.Error()))

diff --git a/pkg/handler/validate_test.go b/pkg/handler/validate_test.go
@@ -37,7 +37,7 @@ var _ = Describe("Handler ", func() {
 			c.Request, _ = http.NewRequest("POST", "/v1/validate", bytes.NewReader([]byte(stringDataAsYAML)))
 			c.Request.Header.Set("Content-Type", "application/x-yaml")
 
-			sealer.EXPECT().Validate(gomock.Any()).Return(nil)
+			sealer.EXPECT().Validate(gomock.Any(), gomock.Any()).Return(nil)
 
 			h.Validate(c)
 
@@ -50,7 +50,7 @@ var _ = Describe("Handler ", func() {
 			c.Request, _ = http.NewRequest("POST", "/v1/validate", bytes.NewReader([]byte(stringDataAsYAML)))
 			c.Request.Header.Set("Content-Type", "application/x-yaml")
 
-			sealer.EXPECT().Validate(gomock.Any()).Return(errors.New("Validation failed"))
+			sealer.EXPECT().Validate(gomock.Any(), gomock.Any()).Return(errors.New("Validation failed"))
 
 			h.Validate(c)
 

diff --git a/pkg/mocks/seal/mock.go b/pkg/mocks/seal/mock.go
diff --git a/pkg/seal/seal.go b/pkg/seal/seal.go
@@ -19,7 +19,7 @@ type Sealer interface {
 	Raw(data Raw) ([]byte, error)
 	Certificate(ctx context.Context) ([]byte, error)
 	Seal(outputFormat string, secret io.Reader) ([]byte, error)
-	Validate(secret io.Reader) error
+	Validate(ctx context.Context, secret io.Reader) error
 }
 
 var _ Sealer = &apiSealer{}
@@ -101,9 +101,9 @@ func (a *apiSealer) Raw(data Raw) ([]byte, error) {
 	return buf.Bytes(), nil
 }
 
-func (a *apiSealer) Validate(secret io.Reader) error {
+func (a *apiSealer) Validate(ctx context.Context, secret io.Reader) error {
 	return kubeseal.ValidateSealedSecret(
-		context.TODO(),
+		ctx,
 		a.clientConfig,
 		a.ss.Namespace,
 		a.ss.Service,