Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation functionality (#132) #145

Merged
merged 28 commits into from
May 13, 2023
Merged

Validation functionality (#132) #145

merged 28 commits into from
May 13, 2023

Conversation

rowi1de
Copy link
Contributor

@rowi1de rowi1de commented May 12, 2023 •
edited
Loading

@rowi1de rowi1de changed the title Implement validation Validation functionality (#132) May 12, 2023
@rowi1de rowi1de mentioned this pull request May 12, 2023
Closed
@bakito
Copy link
Owner

bakito commented May 12, 2023

@rowi1de Thank you very much for taking over

bakito
bakito requested changes May 12, 2023
View reviewed changes
pkg/handler/validate.go Outdated Show resolved Hide resolved
pkg/seal/seal.go Outdated Show resolved Hide resolved
pkg/seal/seal.go Outdated Show resolved Hide resolved
bakito
bakito reviewed May 12, 2023
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@rowi1de rowi1de requested a review from bakito May 12, 2023 21:11
@bakito bakito merged commit 796709f into bakito:main May 13, 2023
@bakito
Copy link
Owner

bakito commented May 13, 2023

@rowi1de Looks very good.

Thank you very much for your effort!

@rowi1de
Copy link
Contributor Author

rowi1de commented May 13, 2023

@rowi1de Looks very good.

Thank you very much for your effort!

Welcome @bakito 🙌🏻 thanks for the support
And kudos to @tiithansen who did most of it 😇

@rowi1de
Copy link
Contributor Author

rowi1de commented May 13, 2023

Sidenote: maybe you want to enable squash & merge for your PRs 😇

@bakito
Copy link
Owner

bakito commented May 13, 2023

Sidenote: maybe you want to enable squash & merge for your PRs 😇

It normally is, didn't realize it was changed, whe I merged until it was to late. 🥺

bakito added a commit that referenced this pull request May 13, 2023
@bakito
Merge pull request #145 from rowi1de/main
7b56c9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakito bakito bakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature to validate sealed secrets via web and API
3 participants
@rowi1de @bakito @tiithansen