Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test Coverage Check #1090

Merged
merged 33 commits into from
Mar 31, 2014
Merged

Adding Test Coverage Check #1090

merged 33 commits into from
Mar 31, 2014

Conversation

tarunc
Copy link
Contributor

@tarunc tarunc commented Mar 27, 2014

Ready to Merge Do Not Merge

This upgrades several grunt dependencies and is an attempt to make the build pass only when coverage is above a certain threshold. Note that the coverage report is not healthy (only one file is shown-- the concatenated, built one.)

Note:

  • I broke up the templates from the concatenated build file to provide actual coverage reports only for tests. So the templates are included differently in the tests than in the actual code.
  • Coverage is around 75%. Goal should be in the next couple weeks to get it up to 90% like the rest of balanced.

I took out some tests that were failing too. I have to add these back in. They are added back in

@tarunc tarunc changed the title Adding Test Coverage Adding Test Coverage Check Mar 27, 2014
@tarunc
Copy link
Contributor Author

tarunc commented Mar 27, 2014

@mjallday @cohitre Would love your opinion on this.

The Balanced Dashboard

[![Build Status](https://travis-ci.org/balanced/balanced-dashboard.png?branch=master)](https://travis-ci.org/balanced/balanced-dashboard)
[![Coverage Status](https://coveralls.io/repos/balanced/balanced-dashboard/badge.png)](https://coveralls.io/r/balanced/balanced-dashboard)
[![Code Climate](https://codeclimate.com/github/balanced/balanced-dashboard.png)](https://codeclimate.com/github/balanced/balanced-dashboard)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cohitre
Copy link
Contributor

cohitre commented Mar 27, 2014

I like this. I'm down for this.

@tarunc
Copy link
Contributor Author

tarunc commented Mar 28, 2014

@mjallday said that he would love to see source map support. Thus, I'm going to try and implement what is recommended by this issue. It might not play nice with neuter but we will see.

@cohitre
Copy link
Contributor

cohitre commented Mar 28, 2014

looks like the build is breaking with a legit failure?

@tarunc
Copy link
Contributor Author

tarunc commented Mar 29, 2014

Yup, I've been trying to replace neuter with concat-in-order

@tarunc
Copy link
Contributor Author

tarunc commented Mar 31, 2014

@cohitre this should be ready to go now.

Note that I ended up not replacing neuter with concat-in-order. We still need to do that to implement file by file coverage.

cohitre added a commit that referenced this pull request Mar 31, 2014
Adding Test Coverage Check
@cohitre cohitre merged commit 13e7ce8 into balanced:master Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants