Contacts endpoint #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sandbox dummy data - Table for contacts - Filtering support - Endpoint for ?q=contact&filter=x
Closed
jamietanna
reviewed
Nov 11, 2021
Comment on lines
+13
to
+15
| } else { | ||
| return null | ||
| } |
There was a problem hiding this comment.
This shouldn't be needed, as it'd return null / undefined anyway?
Suggested change
| } else { | |
| return null | |
| } |
There was a problem hiding this comment.
I get the following from Standard.js without returning the null:
Array.prototype.map() expects a value to be returned at the end of arrow function. (array-callback-return)
There was a problem hiding this comment.
Interesting - fair enough!
|
Awesome, thanks 🙌 We'd need to hook this in with Micropub's CRUD, too, I'd say |
|
Releasing. NB: #22 is for adding the Micropub actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20