Revert "Use dark theme by default" #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab0b9e1.
delete-merged-branch
bot
deleted the
revert-1546-feat-default-dark-theme
branch
barryvdh
added a commit
that referenced
this pull request
Mar 31, 2024
|
I still think it should have ignition as a fallback #1535😄. 'theme' => env('DEBUGBAR_THEME') ?: env('IGNITION_THEME', 'auto'), |
|
Yeah but I think for debugbar it's usually different than the error page. I think it makes a bit sense to just follow the browser. |
|
Thank you! Having to publish config files for every project was quite annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1546
It seems not so popular, so I'll consider reverting it back the 'auto'.
What do you prefer? Thumbs up for auto, down for dark.