Cleanup + fix for regression since UI refinement branch #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost, but i can handle it now 👍 |
|
Hmm, that would trigger my OCD still :) more than happy to reduce the width more. Seems it would need another trim of 10px on either side. |
erikn69
reviewed
Apr 4, 2024
| @@ -313,10 +313,6 @@ dl.phpdebugbar-widgets-kvlist dd.phpdebugbar-widgets-value.phpdebugbar-widgets-p | |||
| background: transparent; | |||
| } | |||
|
|
|||
| dl.phpdebugbar-widgets-kvlist dt { | |||
| width: calc(25%-10px); | |||
There was a problem hiding this comment.
after this was removed
now you can no longer read the model names
Models tab, Jobs tab
This was referenced Apr 4, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed invalid width calculation. I assumed it fixed the aligningment of the dt element, but as @parallels999 mentioned here UI refinements #1601 (comment) its invalid CSS and doesn't do anything. The alignment must've been fixed by something else.
Brought back the padding of the search bar container in the messages tab to prevent overlap on the scrollbar. See UI refinements #1601 (comment)
Merged duplicate selector
dl.phpdebugbar-widgets-kvlist dt