Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code converted into Object Oriented Approach #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Code converted into Object Oriented Approach #1

wants to merge 4 commits into from

Conversation

emekgozluklu
Copy link

Since the nested function structure is not useful, I changed the code using Object Oriented Approach. It provides:

  • Other people can import and use this class with their datasets
  • No need to pass attributes as arguments. Used class attributes.
  • Methods of the class can be runned seperately for observations.
  • The code is more clean, readable and documentable.

Missing requirements.txt and .gitignore files are added.

@emekgozluklu
add requirements.txt file
31b2d48
@emekgozluklu
add .gitignore file
f135d98
@emekgozluklu
add __name__ condition for main scope
b89fc8d
@emekgozluklu
fixed nested function structure
916abc0 
nested functions are not usable. using class based approach instead, makes things easier and more useful owing to methods, shared variables etc. Also, people might want to integrate this class to their own projects. It is not possible to do so with nested function structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@emekgozluklu