Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java_tools #18774

Closed
cushon opened this issue Jun 26, 2023 · 5 comments
Closed

Update java_tools #18774

cushon opened this issue Jun 26, 2023 · 5 comments
Assignees
Labels

Comments

@cushon
Copy link
Contributor

cushon commented Jun 26, 2023

There have been a couple of recent Java toolchain fixes that improve compatibility with JDK 21 that it would be nice to get into 6.3.0:

The first one has been merged into 6.3.0, the second one hasn't yet.

I think both changes will require a java_tools release to be visible, would it be possible to include both in 6.3.0 and then cut another java_tools release?

cc @kshyanashree @comius @hvadehra

@iancha1992
Copy link
Member

@cushon hi, we can absolutely assist with cherry-picking the second one. But we'll need you to give us the commit ID or push to the master so that we can merge to the release-6.3.0 branch. We can communicate on the original issue: #18743.

@cushon
Copy link
Contributor Author

cushon commented Jun 26, 2023

@iancha1992 to double-check, can you also do a java_tools release (similar to the example in #17427)?

Just cherry-picking the fixes into 6.3.0 isn't sufficient, the prebuilt tools also have to be updated and then then the java_tools release containing those fixes has to be cherry-picked

@iancha1992
Copy link
Member

iancha1992 commented Jun 27, 2023

@iancha1992 to double-check, can you also do a java_tools release (similar to the example in #17427)?

Just cherry-picking the fixes into 6.3.0 isn't sufficient, the prebuilt tools also have to be updated and then then the java_tools release containing those fixes has to be cherry-picked

Sure!

cc: @bazelbuild/triage

@keertk
Copy link
Member

keertk commented Jun 27, 2023

@bazel-io fork 6.3.0

@keertk
Copy link
Member

keertk commented Jul 11, 2023

java_tools release: https://github.com/bazelbuild/java_tools/releases/tag/java_v12.4
rules_java release: https://github.com/bazelbuild/rules_java/releases/tag/6.2.1
PR to be merged to master: #18810
cherry-pick into 6.3: #18868

@keertk keertk closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants