-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArrayIndexOutOfBoundsException in turbine with JDK 21 class files #18743
Comments
@bazel-io flag |
@bazel-io fork 6.3.0 |
@cushon Was this pushed? If yes, then can you please direct me to the PR or commit ID so we can cherry-pick to 6.3.0? |
@iancha1992 It was merged as aff3361 |
@cushon Looks like this is a jar file change. I'm trying to cherrypick this commit, but can't due to conflicts. Any advice? |
Is the baseline for 6.3.0 from around October 2022? I didn't realize it was that old. There have been a few updates of turbine since then, and the version in 6.3.0 hasn't got the last few updates:
We just want the latest version of |
The merge base with master for all 6.x is 6.0 (so indeed Oct 2022). 6.3.0 is based on 6.2.X, which is based on 6.1.X, etc. Liam, if you could prepare the PR against 6.3.0, that would be great. It should be as simple as checking out the |
Done: #18803 |
@cushon Can we close this as resolved? |
Maybe I'm holding it wrong, but I'm still seeing this exception with JDK21 and Bazel 6.3.0 and 6.3.2:
|
@hvadehra any ideas? I wonder if the fix needed a rules_java update as well for the fix to make it into the archive of Java tools, and that didn't happen for 6.3.0 |
Hm, it looks like updating to a newer version of |
Bazel at head is still on Error Prone 2.20.0, the version with the crash: Line 85 in b85f2d1
I'll update it, but it'll take some time to propagate to a |
Thanks! That's the solution I've taken so far in my in-progress change. MemberName also catches a few other issues which we'll need to clean up, but am going to hold off until I can re-enable it. |
#18743 (comment) Closes #19711. PiperOrigin-RevId: 570764074 Change-Id: Ie3e1aff66d98b0220b25ccaea6ad1fc2c3d80b42
This fixes a bug with dependencies created with JDK 21 javac. bazelbuild/bazel#18743
This fixes a bug with dependencies created with JDK 21 javac. bazelbuild/bazel#18743
I am also seeing this exception with Bazel 6.4.0. It doesn't look like it's fixed. Did the rules_java update work for you @shahms? |
It was a while ago, but ISTR that updating |
Motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85.
Motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85.
@guw I've also hit this one on Bazel 6.4.0 while experimenting with switching to Java 21 in enola-dev/enola#426 for salesforce/bazel-vscode-java#85, and indeed updating |
Motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85.
Originally motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85, but as noted in bazelbuild/rules_java#159 from enola-dev#427 I can't go to 7.3.2 just yet - but bumping at least already to 7.2.0 is a first step!
Originally motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85, but as noted in bazelbuild/rules_java#159 from enola-dev#427 I can't go to 7.3.2 just yet - but bumping at least already to 7.2.0 is a first step!
Originally motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85, but as noted in bazelbuild/rules_java#159 from #427 I can't go to 7.3.2 just yet - but bumping at least already to 7.2.0 is a first step!
Motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85.
Motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85.
Motivated by bazelbuild/bazel#18743, in the context of salesforce/bazel-vscode-java#85.
Fixes bazelbuild/bazel#18743 in CI with JDK 21.
Fixes bazelbuild/bazel#18743 in CI with JDK 21.
Fixes bazelbuild/bazel#18743 in CI with JDK 21.
Fixes bazelbuild/bazel#18743 in CI with JDK 21.
Fixes bazelbuild/bazel#18743 in CI with JDK 21.
Building with class files emitted by the JDK 21 javac will result in crashes like the following:
The latest JDK 21 builds contain some system classes with
MethodParameters
attributes that contain empty names. This change was caused by the fix for JDK-8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default.Turbine was fixed to correctly handle these class files in google/turbine@0f20345, but that change isn't available in Bazel yet.
I opened https://github.com/bazelbuild/bazel/pulls to update turbine. We should merge that fix and cut a
java_rules
release that includes the change before JDK 21 is released in September.The text was updated successfully, but these errors were encountered: