Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbine #18742

Closed
wants to merge 1 commit into from
Closed

Update turbine #18742

wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jun 22, 2023

Built at google/turbine@ca998fa

Includes a fix for reading MethodParameters attributes that contain synthetic parameters without names: #18743

Built at google/turbine@ca998fa

Includes a fix for reading MethodParameters attributes that contain
synthetic parameters without names: google/turbine@0f20345
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 22, 2023
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Jun 22, 2023
@sgowroji sgowroji assigned meteorcloudy and unassigned sgowroji Jun 26, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 26, 2023
@meteorcloudy
Copy link
Member

@sgowroji Please help merge this one, using the third party approach ;)

copybara-service bot pushed a commit that referenced this pull request Jun 26, 2023
Built at google/turbine@ca998fa

Includes a fix for reading MethodParameters attributes that contain
synthetic parameters without names: google/turbine@0f20345

Partial commit for third_party/*, see #18742.

Signed-off-by: Sunil Gowroji <[email protected]>
@sgowroji
Copy link
Member

Its Done @meteorcloudy . Merged at aff3361

@sgowroji sgowroji closed this Jun 26, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants