Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pcic mods #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pcic mods #3

wants to merge 4 commits into from

Conversation

faronium
Copy link

@faronium faronium commented Nov 17, 2019 •
edited
Loading

I made changes to the shiny server to do two things:

  1. Changed the paths to relative in a way that allowed me to run the server from the linux command line. You may not want to implement that.
  2. Modified how the real time data station selection relates to the URLs that download the data and also how the data columns are selected such that a the sensor number can change on datagarrison without necessitating changing the shiny code to grab that correct data column. Uses grepl to match variable to sensor.
    -1) I think I left a browser() statement in there which you may want to refrain from including.

Faron S. Anslow added 4 commits November 15, 2019 01:03
Modified the file paths to relative as R goes to the working director…
f4aa196 
…y that the server.R file is in.

Signed-off-by: Faron S. Anslow <[email protected]>
Cleaned up the long if/then logic tree for relating station names to …
e66f64f 
…URL codes for the stations real time data. Also made generic the selection of data columns so that changing sensor ID numbers don't cause trouble with the column selection.

Signed-off-by: Faron S. Anslow <[email protected]>
Played with station data length change to double number of hours of d…
30a6b86 
…ata.

Signed-off-by: Faron S. Anslow <[email protected]>
Fixed a typo and made some other small changes in code formatting.
b080466 
Signed-off-by: Faron S. Anslow <[email protected]>
@bevingtona
Copy link
Collaborator

Great pull request! Some of these have been addressed, others not. The repo has changed quite a bit so I think we will integrate some pull requests in the next updates. Ex. the data garrison dictionary is very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faronium @bevingtona