Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date/time stamp records twice in report history box when hitting "recommend for acceptance" #2814

Closed
Grulin opened this issue Jan 23, 2024 · 2 comments · Fixed by #2818
Closed

Date/time stamp records twice in report history box when hitting "recommend for acceptance" #2814

Grulin opened this issue Jan 23, 2024 · 2 comments · Fixed by #2818
Assignees
@prv-proton
Labels
Bug Something isn't working High High priority ticket but not critical at this time Tested :) Passed testing

Comments

@Grulin
Copy link
Collaborator

Grulin commented Jan 23, 2024 •
edited by prv-proton
Loading

Describe the Bug
IDIR user with government analyst role double clicks "Recommend for Acceptance" button on assessment page of report and the date/time stamp records twice in report history box.

Expected Behaviour
Should only record date/time stamp once when "Recommend for Acceptance" button is pressed.

Implications
Unnecessary date/time stamp that could cause confusion for recommended for acceptance date.

Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: IDIR Government Analyst

  1. Go to Assessment page of a submitted compliance report
  2. Click on "Recommend for Acceptance" twice quickly or if page does not immediately load
  3. Scroll up to grey text box and see if date/time stamp was recorded twice.
  4. See error

Double time stamp.png

Image
@Grulin Grulin added Bug Something isn't working High High priority ticket but not critical at this time labels Jan 23, 2024
@prv-proton
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @hamed-valiollahi @kevin-hashimoto @prv-proton

@prv-proton prv-proton self-assigned this Jan 24, 2024
prv-proton added a commit that referenced this issue Jan 26, 2024
@prv-proton
Fix: Date/time stamp records twice in report history box when hitting…
d61155a 
… "recommend for acceptance" #2814
@prv-proton prv-proton mentioned this issue Jan 26, 2024
Merged
@prv-proton prv-proton linked a pull request Jan 26, 2024 that will close this issue
Fix: TFRS - Date/time stamp records twice in report history box when hitting "recommend for acceptance" #2814 #2818
Merged
@prv-proton
Copy link
Collaborator

Wasn't able to re-create the bug as the button click will create a pop-up confirmation window. But have added extra check to prevent any duplicate history records from creating.

AlexZorkin pushed a commit that referenced this issue Jan 29, 2024
@prv-proton
Fix: TFRS - Date/time stamp records twice in report history box when …
4e4d85b 
…hitting "recommend for acceptance" #2814 (#2818)

* Fix: Date/time stamp records twice in report history box when hitting "recommend for acceptance" #2814

* fix: minor fix
@Grulin Grulin added the Tested :) Passed testing label Jan 30, 2024
kuanfandevops added a commit that referenced this issue Jan 31, 2024
@kuanfandevops @hamed-valiollahi
@AlexZorkin @kevin-hashimoto @dependabot @protonater @prv-proton
Tracking pull request to merge release-2.14.0 to master (#2737)
e8ee15f 
* update for 2.14.0

* update pr number for 2.14.0

* fix: fix ui category display mismatch for approved transfers.

* fix: update the ui tests for the CreditTransferSigningHistory component

* crunchy related update in pipeline

* fix: attorny address if null/empty

* fix: updated trade effective date to be set upon approval

* chore: Update functions.js, remove unneeded comments

* Bump jinja2 from 3.1.2 to 3.1.3 in /backend

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.2...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix: Effective Date fix for HDE entries-2769

* Feat: Merge January Candidate - 240117 (#2807)

This merge represents a significant effort to align the TFRS application with the latest legislative requirements, improve the user experience, and enhance the overall reliability and functionality of the system. Here is a high-level summary:

1. **User Interface and Experience Improvements:**
   - Enhanced error messages for credit transfer agreement dates and other functionalities to improve clarity and user guidance.
   - Adjustments in the UI, particularly in the Excel export feature and the 'Edit Organization' page, for better data readability and consistency.

2. **Legislative Compliance Updates:**
   - Removal of outdated options (e.g., the year 2023) from various dropdown menus to align with current legislation.
   - Introduction of compliance unit concepts in compliance reports, replacing previous credits and debits systems.
   - Adjustments to the compliance report model and related queries to improve loading times and data management.
   - Various bug fixes and updates related to compliance report generation and submission, including handling negative balances and reserve compliance units.

3. **System Enhancements and Bug Fixes:**
   - Removal of redundant caching logic to ensure updated details are displayed.
   - Significant backend updates, including Django version bump from 3.2.20 to 3.2.23.
   - Addition of new features like the maxCredits service method and more flexible filtering for organization status.
   - A multitude of bug fixes, including UI corrections, compliance unit calculations, and test case enhancements.

4. **Development and Deployment Process Improvements:**
   - Implementation of new pipelines and build processes for both frontend and backend, enhancing the deployment workflow.
   - Addition of unit tests and continuous integration steps to ensure code stability and reliability.

5. **Label and Terminology Updates:**
   - Comprehensive updates to labels and terminology across various views and functionalities, aligning with the new act.
   - Specific focus on compliance reports, transaction types, and dashboard displays to ensure clarity and legislative compliance.

6. **Database and Data Handling Enhancements:**
   - Database migrations to support new features and legislative changes.
   - Optimization of code and data handling processes, including compliance report spreadsheet updates and handling of different scenarios in compliance unit calculations.

* add backendKeycloakCertsUrl

* fix: fix incorrect button label in draft initiative agreement issuance (#2811)

* fix: fix unresponsive filter input in id column for transactions table (#2815)

* Fix: TFRS - Compliance summary rounding discrepancy in supplemental reporting #2817 (#2819)

* fix: update act citations in transaction history (#2820)

* Fix: TFRS - Date/time stamp records twice in report history box when hitting "recommend for acceptance" #2814 (#2818)

* Fix: Date/time stamp records twice in report history box when hitting "recommend for acceptance" #2814

* fix: minor fix

* Fix: TFRS - Issues with the effective date for transactions entered using the Historical Data Entry feature #2821 (#2822)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Hamed Valiollahi Bayeki <[email protected]>
Co-authored-by: Alex Zorkin <[email protected]>
Co-authored-by: Kevin Hashimoto <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: kevin-hashimoto <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Prashanth Venkateshappa <[email protected]>
Co-authored-by: Prashanth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prv-proton prv-proton

Labels
Bug Something isn't working High High priority ticket but not critical at this time Tested :) Passed testing
Projects
None yet
Milestone
No milestone
2 participants
@prv-proton @Grulin