Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label changes #1643

Merged
merged 18 commits into from
Jan 30, 2020
Merged

Label changes #1643

merged 18 commits into from
Jan 30, 2020

Conversation

amichard
Copy link
Contributor

@amichard amichard commented Jan 24, 2020 •
edited
Loading

Changelog:

  • ESLint fixes
  • Renamed Exclusion Report to Exclusion Agreements (Label)
  • Changed tab from Exclusion Agreement to Exclusion Agreements
  • Slightly changed logic for showing "Upon acceptance" message
  • Dropdown indicator for Exclusion Reports

amichard and others added 16 commits November 27, 2019 13:35
@amichard
ESLint fixes
9a7ee9e
@plasticviking
load supplemental report on create
a5ed8ed
@plasticviking
fix an error due to an undefined reference on director acceptance fro…
781da82 
…m assessment page
@plasticviking
digits seperator in compliance assessment page
892d928
@amichard
Report History should now add PST at the end
507f219
@amichard
Reordered the buttons for download xls and creating supplemental report
07cd4b5
@amichard
Merge branch 'master' into eslint-fixes
4ccd2ba
@amichard
Merge branch 'supplemental-report-load-on-create' into eslint-fixes
effbf50
@amichard
Merge branch 'reorder-buttons' into eslint-fixes
5a80dba
@amichard
Merge branch 'report-history-timestamp' into eslint-fixes
2139959
@amichard
ESLint fixes
ac251bb
@amichard
More eslint fixes
d2ff133
@amichard
fixed merge conflicts
86a9b45
@amichard
Changed to isRequired. Defaulting these kinds of booleans might lead …
21eaf33 
…to unexpected behaviours
@amichard
Minor label changes and condition changes on when to show certain mes…
08f6746 
…sages
@amichard
Renamed report to agreements
7a46c24
@amichard amichard self-assigned this Jan 24, 2020
@repo-mountie
Copy link

repo-mountie bot commented Jan 24, 2020

@amichard When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 1000 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs.

Here are a few thoughtful articles on what a good PR should look like:

The Anatomy of a Perfect Pull Request

Optimal Pull Request Size

Best Practices for Code Review

Pro Tip

  • Add the command /bot-ignore-length in the body (preferably as the last line) of a PR if you have a legitimate reason for lengthy PR.

@kuanfandevops kuanfandevops self-requested a review January 30, 2020 20:00
kuanfandevops
kuanfandevops approved these changes Jan 30, 2020
View reviewed changes
Copy link
Collaborator

@kuanfandevops kuanfandevops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kuanfandevops kuanfandevops added this to the 1.6.0 milestone Jan 30, 2020
@kuanfandevops kuanfandevops merged commit a036ac0 into bcgov:master Jan 30, 2020
@amichard amichard deleted the label-changes branch March 17, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuanfandevops kuanfandevops kuanfandevops approved these changes

@plasticviking plasticviking Awaiting requested review from plasticviking

Assignees

@amichard amichard

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amichard @kuanfandevops @plasticviking