Revert "Revert "Schedule Assesment updates"" #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amichard
approved these changes
Mar 3, 2020
kuanfandevops
added a commit
that referenced
this pull request
Mar 23, 2020
* Revert "Revert "Schedule Assesment updates (#1646)" (#1650)" (#1654) This reverts commit 9163f9b. * Revert "Revert "about to roll back schedule a (#1647)" (#1651)" (#1655) This reverts commit 211f5d4. * Added a check on the snapshot object before loading * Added a fallback for the snapshot so it always has something * Fixed an error where the page crashes if you switch from exclusion report to compliance report * Minor label change * Changed the label for the changelog. Assessment tab no longer shows up on rejected. Create Supplemental button shows up on rejected * Fixed some dashboard and logic issues * Fixed a permission bug with Compliance Reporting with the Signing Authority Role * Fix tests * Various front-end fixes in regards to permission checks * Added a new business logic to add a year to the expiration date when fetching fuel codes in schedule b Co-authored-by: Richard Tan <[email protected]>
kuanfandevops
deleted the
revert-1650-revert-1646-schedule-assessment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1650