Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift v4 migration #1696

Merged
merged 78 commits into from
Feb 19, 2021
Merged

Openshift v4 migration #1696

merged 78 commits into from
Feb 19, 2021

Conversation

kuanfandevops
Copy link
Collaborator

No description provided.

@repo-mountie
Copy link

repo-mountie bot commented Nov 25, 2020

@kuanfandevops When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 1000 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs.

Here are a few thoughtful articles on what a good PR should look like:

The Anatomy of a Perfect Pull Request

Optimal Pull Request Size

Best Practices for Code Review

Pro Tip

  • Add the command /bot-ignore-length in the body (preferably as the last line) of a PR if you have a legitimate reason for lengthy PR.

@kuanfandevops kuanfandevops merged commit 7026e46 into master Feb 19, 2021
@kuanfandevops kuanfandevops deleted the openshift-v4-migration branch February 19, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants