Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed internal comments showing up for supplier spreadsheet #1740

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Fixed internal comments showing up for supplier spreadsheet #1740

merged 1 commit into from
Apr 14, 2021

Conversation

amichard
Copy link
Contributor

Changelog:

  • Added a user check to the spreadsheet builder so we can check for permission on whether they can view internal comments

@amichard amichard self-assigned this Apr 14, 2021
@amichard amichard changed the base branch from master to release-1.6.23.1 April 14, 2021 15:27
kuanfandevops
kuanfandevops approved these changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@kuanfandevops kuanfandevops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kuanfandevops kuanfandevops merged commit 19a29ad into bcgov:release-1.6.23.1 Apr 14, 2021
kuanfandevops added a commit that referenced this pull request Apr 15, 2021
@kuanfandevops @amichard
Tracking pull request to merge release-1.6.23.1 to master (#1741)
4f09acb 
* update to 1.6.23-1, it was 1.6.22.3, it really should be 1.6.23

* Fixed internal comments showing up for supplier spreadsheet (#1740)

* update pipeline for the release

* only deploy frontend and backend for 1.6.23.1

* added relemase management

Co-authored-by: Richard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuanfandevops kuanfandevops kuanfandevops approved these changes

@emi-hi emi-hi Awaiting requested review from emi-hi

Assignees

@amichard amichard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amichard @kuanfandevops