Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix incorrect labels in initiative agreement issuance transaction - 2772 #2791

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR resolves the issue where the 'Part 3 Award' label and outdated sentence language were displayed for new Initiative Agreement Issuance transactions.

Here are the expected results:

Status Current Sentence Revised Sentence
Draft An award of 500 credits earned by AAA Fuel Company for the completion of Part 3 Agreement milestone(s) has been drafted. 500 compliance units issued to AAA Fuel Company for the completion of a designated action in an Initiative Agreement has been drafted.
Reviewed An award of 500 credits earned by AAA Fuel Company for the completion of Part 3 Agreement milestone(s) has been reviewed. 500 compliance units issued to AAA Fuel Company for the completion of a designated action in an Initiative Agreement has been reviewed.
Approved An award of 500 credits earned by AAA Fuel Company for the completion of Part 3 Agreement milestone(s) has been approved, effective January 11, 2024. 500 compliance units issued to AAA Fuel Company for the completion of a designated action in an Initiative Agreement has been approved, effective January 11, 2024.
Declined An award of 500 credits earned by AAA Fuel Company for the completion of Part 3 Agreement milestone(s) has been declined. 500 compliance units issued to AAA Fuel Company for the completion of a designated action in an Initiative Agreement has been declined.

Note: It seems that the issue with moment in the if statement is also present in other files, for example CreditTransferTextRepresentation.js.

Closes #2772

@AlexZorkin AlexZorkin merged commit 25397e0 into main-release-jan-2024 Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants