Fix: Update Modal ConfirmLabel Logic for Transaction Types - 2789 #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexZorkin
reviewed
Jan 16, 2024
| @@ -517,19 +517,27 @@ class CreditTransferViewContainer extends Component { | |||
| } | |||
|
|
|||
| _modalRecommend (item) { | |||
| const isBuyOrSell = [CREDIT_TRANSFER_TYPES.buy.id, CREDIT_TRANSFER_TYPES.sell.id].indexOf(item.type.id) >= 0; | |||
There was a problem hiding this comment.
I don't think we need to differentiate between Buy or Sell because the button labels should be the same for both. Is this component even used for Initiative Agreements?
There was a problem hiding this comment.
Yes, this modal is used for "Transfers with the Submitted Status" as well as for "Initiative Agreements".
Please check out Justin's comment on the ticket page for more information.
There was a problem hiding this comment.
You're welcome!
Thanks, Alex, for reviewing my PR.
AlexZorkin
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where the modal's
confirmLabelwas not dynamically updating based on different transaction types.Closes #2789