Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit Trade Signing History #413

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

amichard
Copy link
Contributor

#412

We should now have a section in the Credit Trade where it shows who signed the proposal and who reviewed the proposal

Changelog:

  • Added CreditTradeSigningHistory component
  • Added signatures and reviewed property in the Credit Trade
  • Restored the single quotes in CreditTradeHistory (was getting into an infinite loop if I try to import CreditTradeHistory into CreditTrade)
  • Removed Propose Trade permission from Government Director

@amichard amichard added this to the RELEASE v0.3.1 milestone Jun 28, 2018
@amichard amichard self-assigned this Jun 28, 2018
@amichard
Copy link
Contributor Author

Copy link
Contributor

@plasticviking plasticviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kuanfandevops kuanfandevops merged commit 987951b into bcgov:master Jun 29, 2018
@amichard amichard deleted the signing-authority-history branch July 3, 2018 16:02
kuanfandevops pushed a commit that referenced this pull request Sep 19, 2019
We should now have a section in the Credit Trade where it shows who signed the proposal and who reviewed the proposal
Changelog:
Added CreditTradeSigningHistory component
Added signatures and reviewed property in the Credit Trade
Restored the single quotes in CreditTradeHistory (was getting into an infinite loop if I try to import CreditTradeHistory into CreditTrade)
Removed Propose Trade permission from Government Director
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants