Use teardown within the tests instead of addons

#101

CONTRIBUTING.md

@@ -21,10 +21,11 @@ Add the following line to the test file if the extension is required:
 - `load addons-cd` to fake `cd` command (**optional**)
 - `load addons-read` to fake `read` command (**optional**)
 
-Bats restrictions
------------------
-1. **Don't use `setup()` or `teardown()`** bats methods.
-2. Use **`check` instead of bats `run`** to execute a command to test.
+Writing tests
+-------------
+1. **Use `setup()` or `teardown()`** bats methods only in the tests.
+2. Use **`check` instead of bats `run`** to execute a command to be tested.
+3. If `addons-fake` or `addons-git` is used, call `clean-fake` or `clean-git` within a `teardown()` method.
 
 Assertions
 ----------

src/test/addons-fake.bash

@@ -53,9 +53,7 @@ fake-fail() {
     fake "$COMMAND" "$SUBCOMMAND" 100 " " "$@"
 }
 
-teardown() {
-    # @todo #89 Use $BATS_TMPDIR instead of teardown methods for fakes deletion
-    #teardown for bats tests
+clean-fake() {
     if [ -d "$MOCK_DIR" ]; then
         rm -r "$MOCK_DIR"
     fi

src/test/addons-git.bash

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -e
 
-GIT_REPO_DIR="$BATS_TMPDIR/mock-repo"
+GIT_REPO_DIR="/tmp/elegant-git-repo"
 FILE_TO_MODIFY=file
 
 _gilog(){
@@ -36,3 +36,9 @@ add-st-change(){
     add-unst-change "$@"
     _ex git add $FILE_TO_MODIFY
 }
+
+clean-git() {
+    if [ -d "$GIT_REPO_DIR" ]; then
+        rm -rf "$GIT_REPO_DIR"
+    fi
+}

src/test/git-elegant-add.bats

@@ -4,6 +4,9 @@ load addons-common
 load addons-read
 load addons-fake
 
+teardown() {
+    clean-fake
+}
 
 setup() {
     fake-pass git "ls-files -m" src/test/git-elegant

src/test/git-elegant-check.bats

@@ -4,6 +4,10 @@ load addons-common
 load addons-git
 load addons-fake
 
+teardown() {
+    clean-fake
+    clean-git
+}
 
 preconditions() {
     fake-pass git "diff --check"

src/test/git-elegant-clear-local.bats

@@ -10,6 +10,10 @@ setup() {
     fake-pass git "branch -d first"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "exit code is 0 when run 'git-elegant clear-local'" {
   run git-elegant clear-local
   [ "$status" -eq 0 ]

src/test/git-elegant-clone.bats

@@ -11,6 +11,10 @@ setup() {
     fake-pass git "elegant configure --local"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "print message when run 'git-elegant clone'" {
   run git-elegant clone
   [[ "${lines[0]}" =~ "Clonable URL is not set"  ]]

src/test/git-elegant-configure.bats

@@ -22,6 +22,10 @@ setup() {
     fake-pass git "config --local apply.whitespace fix"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "'configure': exit code is 11 when run without arguments" {
   run git-elegant configure
   [ "$status" -eq 11 ]

src/test/git-elegant-feature.bats

@@ -9,6 +9,10 @@ setup() {
     fake-pass git "stash save elegant-git"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "exit code is 0 when run 'git-elegant feature test-feature'" {
   run git-elegant feature test-feature
   [ "$status" -eq 0 ]

src/test/git-elegant-init.bats

@@ -9,6 +9,10 @@ setup() {
     fake-pass git "elegant configure --local"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "exit code is 0 when run 'git-elegant init'" {
   run git-elegant init
   [ "$status" -eq 0 ]

src/test/git-elegant-pull.bats

@@ -3,6 +3,10 @@
 load addons-common
 load addons-fake
 
+teardown() {
+    clean-fake
+}
+
 @test "exit code is 0 when run 'git-elegant pull' without parameters" {
     fake-pass git "fetch --tags"
     fake-pass git pull

src/test/git-elegant-push-after-rebase.bats

@@ -9,6 +9,10 @@ setup() {
     fake-pass git "elegant push"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "exit code is 0 when run 'git-elegant push-after-rebase'" {
   run git-elegant push-after-rebase
   [ "$status" -eq 0 ]

src/test/git-elegant-push.bats

@@ -4,6 +4,10 @@ load addons-common
 load addons-read
 load addons-fake
 
+teardown() {
+    clean-fake
+}
+
 setup() {
     fake-pass git branch *master
     fake-pass git "push -u origin master:master"

src/test/git-elegant-rebase.bats

@@ -8,6 +8,10 @@ setup() {
     fake-pass git "rebase origin/master"
 }
 
+teardown() {
+    clean-fake
+}
+
 @test "exit code is 0 when run 'git-elegant rebase'" {
     run git-elegant rebase
     [ "$status" -eq 0 ]

src/test/git-elegant.bats

@@ -3,6 +3,10 @@
 load addons-common
 load addons-fake
 
+teardown() {
+    clean-fake
+}
+
 @test "print available commands when run 'git-elegant commands'" {
   run git-elegant commands
   [ "${lines[0]}" = "feature" ]