Added AstcBlock and AstcChannel to the forwarded wgpu types.
#14410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ASTC formats can't be programmatically constructed without importing wgpu in addition to bevy.
alice-i-cecile
approved these changes
Jul 22, 2024
alice-i-cecile
added
D-Trivial
|
I wish we had explicit guidance on what types to forward, but the motivation here is solid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
TextureFormat::Astccan't be programmatically constructed without importing wgpu in addition to bevy.Objective
Allow programmatic construction of
TextureFormat::Astcwith no additional imports required.Solution
Exported the two component enums
AstcBlockandAstcChannelused inTextureFormat::Astcconstruction.Testing
I did not test this, the change seemed pretty safe. :)