Merge pull request #307 from billdenney/codefactor

Resolve some codefactor issues
billdenney · Jun 28, 2024 · 3067f93 · 3067f93
2 parents 027ee95 + 6d982d9
commit 3067f93
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/data-raw/sparse/sparse_pk_dataset.R b/data-raw/sparse/sparse_pk_dataset.R
@@ -21,7 +21,7 @@ d_conc <-
   filter(!is.na(Concentration))
 
 stopifnot(all(is.na(d_conc$`Animal ID`)))
-d_conc$`Animal ID` <- 1:nrow(d_conc)
+d_conc$`Animal ID` <- seq_len(nrow(d_conc))
 
 o_conc <-
   d_conc %>%
@@ -37,6 +37,6 @@ d_intervals <-
 o_data <-
   PKNCAdata(o_conc, intervals=d_intervals)
 o_nca <- pk.nca(o_data)
-summary(o_nca, drop.group = c())
+summary(o_nca, drop.group = character())
 as.data.frame(as.data.frame(o_nca))
 
diff --git a/tests/testthat/test-pk.calc.simple.R b/tests/testthat/test-pk.calc.simple.R
@@ -456,7 +456,7 @@ test_that("pk.calc.aucabove", {
 test_that("pk.calc.count_conc", {
   expect_equal(pk.calc.count_conc(1:5), 5)
   expect_equal(pk.calc.count_conc(c(1:2, NA)), 2)
-  expect_equal(suppressWarnings(pk.calc.count_conc(c())), 0)
+  expect_equal(suppressWarnings(pk.calc.count_conc(numeric())), 0)
   expect_equal(suppressWarnings(pk.calc.count_conc(NA)), 0)
 })