Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GATK4 recipe to allow Java 11 (Proposal) #24588

Closed
wants to merge 6 commits into from
Closed

Update GATK4 recipe to allow Java 11 (Proposal) #24588

wants to merge 6 commits into from

Conversation

jfy133
Copy link
Contributor

@jfy133 jfy133 commented Sep 29, 2020

GATK4 has had 'beta' support for Java 11 for almost a year now (since 4.1.4).

I'm dealing with a pipeline that includes tools do not support Java 8 anymore, and being able to run it on Java 11 would be really useful, and GATK is the only package 'holding' this back. I did a search on the GATK github repo issues for bug reports for Java 11 and didn't really see anything recent which suggest to me this should (hopefully) be pretty stable.

The only issue here is that that the Spark compatibility might be affected (See GATK #6671 and #6053), but again I don't see any major incompatibility reports with Java 11.

I don't know what bioconda's approach to 'beta' stuff like this, so I make this as a proposal, and updating the build as it is not a new version of the tool.

Note that I've changed the requirement pinning structure to remove the more than operator, based on following the conda documentation here and here.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jfy133
Copy link
Contributor Author

jfy133 commented Sep 30, 2020

Neither , not | worked for some reason to separate different possible versions.

Despite 9 and 10 versions of java were never released for production use, unfortunately the recipe picks up the conda-forge version of openjdk which includes these version (which are not supported by GATK AFAIK), so using less than/more than doesn't work here.

@jfy133
Copy link
Contributor Author

jfy133 commented Oct 1, 2020

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 1, 2020
@apeltzer
Copy link
Member

apeltzer commented Oct 1, 2020

@bioconda/core any thoughts on this one?

@bgruening
Copy link
Member

I am hesitant to include something that is not supported upstream. @jfy133 why are you not using separate environments? You can not support a one-fits-all environment for eternity. So I guess it's better to decompose your pipeline into separate envs.

@jfy133
Copy link
Contributor Author

jfy133 commented Oct 3, 2020

I am hesitant to include something that is not supported upstream. @jfy133 why are you not using separate environments? You can not support a one-fits-all environment for eternity. So I guess it's better to decompose your pipeline into separate envs.

@bgruening thanks for your input, and is what I expected.

You have a good point about that and I just conferred with @apeltzer and actually it is a misunderstanding on my part - apparently nextflow/nf-core pipelines do support separate containers per process (I thought that was only in a cutting edge version). So I will investigate that instead. Thanks anyway!

@jfy133 jfy133 closed this Oct 3, 2020
@jfy133 jfy133 deleted the gatk4-java branch November 2, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants