Correct BIOMOD_EnsembleModeling when multiple PA datasets (obs and fi…

…t not matching when calling bm_FindOptimStat)
biomodhub · Jun 6, 2024 · 8eaa324 · 8eaa324
1 parent 4318a63
commit 8eaa324
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/R/BIOMOD_EnsembleModeling.R b/R/BIOMOD_EnsembleModeling.R
@@ -666,7 +666,8 @@ BIOMOD_EnsembleModeling <- function(bm.mod,
                     if (all(!eval.lines)) { eval.lines <- !eval.lines }
                   }
                 } else {
-                  eval.lines <- rep(TRUE, length(pred.bm))
+                  eval.lines <- rep(FALSE, length(obs))
+                  eval.lines[as.numeric(rownames(pred.newdata))] <- TRUE
                 }
 
 

diff --git a/docs/articles/news.html b/docs/articles/news.html
diff --git a/vignettes/news.Rmd b/vignettes/news.Rmd
@@ -17,7 +17,9 @@ vignette: >
 
 ##### Bugfix
 
-- 4.2-5-2 : always keep same order for variable names for `new.env` in `BIOMOD_Projection` and `BIOMOD_EnsembleForecasting`
+- 4.2-5-2 :
+  + fixed `BIOMOD_EnsembleModeling` when multiple PA datasets (`obs` and `fit` not matching when calling `bm_FindOptimStat`)
+  + always keep same order for variable names for `new.env` in `BIOMOD_Projection` and `BIOMOD_EnsembleForecasting`
 - 4.2-5-1 :
   + removed `tests/` folder (unused)
   + fixed check for variable names for `new.env` in `BIOMOD_Projection` and `BIOMOD_EnsembleForecasting`