-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative url filter consistently and remove unused post template #182
Conversation
In reference to the snippet you noted, this works OK on https://biopython.org/wiki/Category:Wiki_Documentation but https://lalitnm.github.io/biopython.github.io/wiki/Category:Wiki_Documentation are currently broken - they still assume an absolute URL starting I guess this needs the same relative URL filter applied here? |
I would guess we'll need something like this?
to:
(Untested) |
I got you. Let me fix this too.
Let me test this as well. |
Now, only one place left where biopython.github.io/_layouts/post.html Line 17 in 3e4d073
@peterjc as far as I understand, we are not using that layout anywhere in website. Should we also change that file? Also test this state at https://lalitnm.github.io/biopython.github.io. |
This is also my understanding. This template is for blogs, isn't it? However, if we keep the template then you should also add the filter here. Or delete the template. |
I think Markus is probably right - and we might as well fix the currently unused post template. |
Yeah, that is what it means.
Sure, let me rename it as
Sure, let me remove that. |
Looks like we forgot about this cleanup work - applying now, thanks! |
Follow up pull request on #181.
@MarkusPiotrowski I added
relative_url
at couple of places. But couldn't find any use ofbiopython.github.io/_layouts/wiki.html
Line 7 in 3e4d073
You can see a live demo of this state of website at https://lalitnm.github.io/biopython.github.io.
Please let me know if this pull request can be improved further.