Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a task for fastq-filter #322

Merged
merged 4 commits into from
Jun 13, 2023
Merged

add a task for fastq-filter #322

merged 4 commits into from
Jun 13, 2023

Conversation

DavyCats
Copy link
Contributor

Checklist

  • Pull request details were added to CHANGELOG.md.
  • Documentation was updated (if required).
  • parameter_meta was added/updated (if required).
  • Submodule branches are on develop or a tagged commit.

rhpvorderman
rhpvorderman approved these changes Jun 13, 2023
View reviewed changes
fastqFilter.wdl Outdated
Int? minLength
Int? maxLength

String memory = "4GiB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1GiB should be ample. The tool only has one fastq record/pair in memory at each time.

@DavyCats DavyCats merged commit 25477c5 into develop Jun 13, 2023
1 check passed
@DavyCats DavyCats deleted the fastq-filter branch June 13, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhpvorderman rhpvorderman rhpvorderman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavyCats @rhpvorderman