This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Refactor pricenode #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This move avoids the use of bisq.pricenode subpackages from a class within that package, eliminating the cyclic package dependencies that doing so causes.
This appears to have been copied and pasted from BisqAppMain in the bisq-network/exchange repository.
bisq.price.node reads nicely, but 'app' packaging is the convention elsewhere, is immediately intention-revealing, and sorts alphanumerically to the top, helping the reader discover its nature as an entry point.
Per https://docs.travis-ci.com/user/notifications/#Configuring-Slack-notifications the default setting for Travis Slack notifications is to send a message on every successful build. This commit changes this frequency, such that notifications are always sent when builds fail and only sent when builds succeed after a previous failure.
This is necessary now that bisq-pricenode is once again dependent on bisq-p2p in order to avoid failures like those seen at https://travis-ci.org/cbeams/bisq-pricenode/builds/353714246#L671-L689.
IDEA does strips EOF newlines in these files, so this commit adds an exception to the usual rule about inserting them. This will avoid spurious whitespace diffs on these files in the future.
This setting is actually necessary only in bisq-common, but it has been added to the shared codeStyles/Project.xml in bisq-network/dao so as to be able to copy the same configuration file to all bisq-* projects.
Problem: bisq-network/style#3 indicates code should be wrapped at 120 characters, but it is likely that people will forget and that this habit will only change slowly. Solution: Configure IDEA to wrap lines automatically when typing past 120 characters, forcing the reminder to happen in real time. If this becomes a nuisance, we can remove it later. Note that this change also explicitly sets the RIGHT_MARGIN value to 120, even though this is already IDEA's default value. This is simply to be explicit and self-documenting.
For reasons detailed in bisq-network/bisq-p2p@b1528bf3.
Problem: Gradle's default 30 second HTTP timeouts often cause bisq-* component builds to fail when resolving dependencies built on the fly via JitPack, e.g.: https://travis-ci.org/bisq-network/bisq-core/builds/356777615#L518-L525. Solution: Increase timeout values to 120 seconds, which should be more that sufficient. See: - gradle/gradle#3370 - gradle/gradle#3371 - gradle/gradle#4629
1 task
This reverts commit d46365f.
And in particular, document the semantics of our use of Spring's @order annotation per review comments at bisq-network/bisq-pricenode#7 (comment).
|
Ok, this PR has (at long last) been merged. I'm holding off on tagging v0.7.1 until we cut releases of underlying bisq-* dependencies, which will happen soon as part of the forthcoming bisq-desktop v0.7.0 release. In the meantime, it would be good if all @bisq-network/pricenode-operators could at least do a test deployment of commit 545887c, to make sure you understand everything, and that we root out any issues before tagging v0.7.1. |
6 tasks
mrosseel
pushed a commit
to mrosseel/pricenode
that referenced
this pull request
Jun 12, 2018
This reverts commit 4951989 for reasons at bisq-network#7 (comment).
mrosseel
pushed a commit
to mrosseel/pricenode
that referenced
this pull request
Jun 12, 2018
This reverts commit 5a67f54 for reasons at bisq-network#7 (comment).
mrosseel
pushed a commit
to mrosseel/pricenode
that referenced
this pull request
Jun 12, 2018
mrosseel
pushed a commit
to mrosseel/pricenode
that referenced
this pull request
Jun 12, 2018
Per review comments at bisq-network#7 (comment)
mrosseel
pushed a commit
to mrosseel/pricenode
that referenced
this pull request
Jun 12, 2018
Also remove #movingAverage fee rate smoothing logic per review comments at bisq-network#7 (comment) IMPORTANT: @bisq-network/pricenode-operators must remove the first of their three command line parameters, as the first has been removed and no longer represents 'capacity'
mrosseel
referenced
this pull request
in mrosseel/pricenode
Jun 12, 2018
And in particular, document the semantics of our use of Spring's @order annotation per review comments at bisq-network/bisq-pricenode#7 (comment).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a number of pure refactorings after the initial migration to the new repository in #2.