Add Tether (ERC20) #5735
Merged
Add Tether (ERC20) #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
in:altcoins
is:no-priority
|
@jmacxx This PR is missing the required test for the token. I think this check wasn't ported to the GitHub build system when we had to switch build systems. |
ripcurlx
suggested changes
Sep 30, 2021
ghost
requested a review
from
ripcurlx
approved these changes
Oct 4, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altcoin Tether (ERC20) added using code originally submitted in #4457 and #4434
As requested here bisq-network/proposals#170 (comment)
and here bisq-network/projects#60 (comment)
As discussed on the dev call with @leo816, Tether will have no price feed (same as other stablecoins on Bisq). Makers will need to enter the fixed offer price.