Preparations for new trade protocol #6800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage message, NodeAddress peer)` method with a super call to the concrete seller classes to make the protocol flow more transparent. Remove comments Signed-off-by: HenrikJannsen <[email protected]>
… static field TRADE_PROTOCOL_VERSION Signed-off-by: HenrikJannsen <[email protected]>
…ersion5Activated method. Set tradeProtocolVersion to 5 after activation date. Maker will republish their offers after version has increased. Takers who have not updated cannot take such offers. Signed-off-by: HenrikJannsen <[email protected]>
…ocol to BaseSellerProtocol Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
…otocol and BaseSellerProtocol Add v5 classes. Make BaseBuyerProtocol and BaseSellerProtocol package private. Signed-off-by: HenrikJannsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation PR for the new trade protocol changes (bisq-network/proposals#421).
As we need more request/response roundtrips it is better to implement it with new protocol classes. It also lowers the risks for the current protocol as it will have no changes in those protocol classes.
This PR contains mainly refactorings and support for detecting the version 5 trade protocol.
The new protocol classes are just plain copies at that moment.