-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses tslib without depending on it #3
Labels
Comments
I'm thinking it makes the most sense to set importHelpers to false? This lib will not be used so much in browsers, so bundle size isn't all that important? |
I agree. AFAIK, this doesn't need to be a major bump either. Wanna push a PR on it? |
simenandre
added a commit
that referenced
this issue
Mar 15, 2021
Changes `importHelpers` to `false`. fixes #3
simenandre
added a commit
that referenced
this issue
Mar 15, 2021
Changes `importHelpers` to `false`. fixes #3
🎉 This issue has been resolved in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tsconfig sets
"importHelpers": true,
, which causes the emitted js code to use thetslib
library. However, the package.json does not include a dependency ontslib
. Projects that usefiken-js
but don't usetslib
will crash on startup.The text was updated successfully, but these errors were encountered: