Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses tslib without depending on it #3

Closed
runeh opened this issue Mar 15, 2021 · 3 comments · Fixed by #4
Closed

Uses tslib without depending on it #3

runeh opened this issue Mar 15, 2021 · 3 comments · Fixed by #4
Labels
released

Comments

@runeh
Copy link

runeh commented Mar 15, 2021

The tsconfig sets "importHelpers": true,, which causes the emitted js code to use the tslib library. However, the package.json does not include a dependency on tslib. Projects that use fiken-js but don't use tslib will crash on startup.
@runeh
Copy link
Author

runeh commented Mar 15, 2021

I'm thinking it makes the most sense to set importHelpers to false? This lib will not be used so much in browsers, so bundle size isn't all that important?

@simenandre
Copy link
Member

I agree. AFAIK, this doesn't need to be a major bump either. Wanna push a PR on it?

simenandre added a commit that referenced this issue Mar 15, 2021
@simenandre
fix: Remove tslib dependency
95617eb 
Changes `importHelpers`  to `false`.

fixes #3
@simenandre simenandre mentioned this issue Mar 15, 2021
Merged
simenandre added a commit that referenced this issue Mar 15, 2021
@simenandre
fix: Remove tslib dependency (#4)
2e480cd 
Changes `importHelpers`  to `false`.

fixes #3
github-actions bot pushed a commit that referenced this issue Mar 15, 2021
@semantic-release-bot
chore(release): 1.0.2 [skip ci]
70e433a 
## [1.0.2](v1.0.1...v1.0.2) (2021-03-15)

### Bug Fixes

* Remove `tslib` dependency ([#4](#4)) ([2e480cd](2e480cd)), closes [#3](#3)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove tslib dependency bjerkio/fiken-js
2 participants
@runeh @simenandre