Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieConfig not being used on client #7

Closed
Pikachews opened this issue Jul 14, 2020 · 3 comments
Closed

CookieConfig not being used on client #7

Pikachews opened this issue Jul 14, 2020 · 3 comments
Labels
bug Something isn't working released

Comments

@Pikachews
Copy link

I noticed that my cookieConfig settings weren't taking effect on the client, whether it was changing the persist key or the cookie expiration.

The root cause seems to be that the cookieConfigs are only being used on the server.

storage: new CookieStorage(cookies, {
...sharedCookieConfig,
setCookieOptions: {
...sharedCookieConfig.setCookieOptions,
httpOnly: false, // Allow modifications on the client side
},
}),

Whereas on the client, no cookieConfig is being used:

storage: new CookieStorage(ClientCookies),

storage: new CookieStorage(cookies),

@bjoluc bjoluc closed this as completed in 37d625e Jul 14, 2020
bjoluc pushed a commit that referenced this issue Jul 14, 2020
### [1.1.2](v1.1.1...v1.1.2) (2020-07-14)

### Bug Fixes

* Pass `cookieConfig` to `CookieStorage` on client side ([37d625e](37d625e)), closes [#7](#7)
@bjoluc
Copy link
Owner

bjoluc commented Jul 14, 2020

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bjoluc
Copy link
Owner

bjoluc commented Jul 14, 2020

Wow, the bot was faster than me 😄 Anyway, thanks for pointing this out!

@Pikachews
Copy link
Author

Thanks for the quick fix!

@bjoluc bjoluc added the bug Something isn't working label Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants