Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: feature to make use of rustls instead of native-tls #195

Closed
GlenDC opened this issue May 13, 2022 · 3 comments
Closed

Request: feature to make use of rustls instead of native-tls #195

GlenDC opened this issue May 13, 2022 · 3 comments

Comments

@GlenDC
Copy link

GlenDC commented May 13, 2022

Hi! First of all a giant amount of gratitude for all of you for providing this crate.
It worked out of the box and was very pleasant to use.

With that being said. This is currently my only dependency through which
I require native-tls support, all other dependencies that I use do already allow rustls support.
Is it on the roadmap already to provide rustls support, be it an opt-in feature. It would allow
me to simplify my production processes.

If there is something I can help in this regards to assist in making this happen you can let me know as well.
And once again, thanks for developing and maintaining this crate, it's fantastic :)

@blackbeam
Copy link
Owner

Hi. Yeah, it's on the roadmap, but I'm sure when I would be able to ship it (not much spare time at the moment).

If there is something I can help in this regards to assist in making this happen you can let me know as well.

It would be great if someone could come up with a PR. Actually blackbeam/rust-mysql-simple#295 covers all the details and may be used as a reference implementation.

@GlenDC
Copy link
Author

GlenDC commented May 14, 2022

Ok fantastic, going to put it on my personal backlog. Will see if I get to it, thanks for giving me the pointer!
For now it's not a blocker, but as I said, given it is the only dependency it would be a shame if in the end it is. the reason I need to support the native tls requirements just because of it.

Also once again thx for making this crate!

@TobiasDeBruijn
Copy link
Contributor

PR is ready I'd say! I need to get OpenSSL out of my dependency tree, but do want to switch to the async version of the mysql crate. Awesome work on both!

blackbeam added a commit that referenced this issue Nov 12, 2022
Implemented rustls support, fixes #195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants