Remove waker from wait list when GetConn is dropped #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloneable
force-pushed
the
queued-waker-removal-on-getconn-drop
branch
2 times, most recently
from
cf771f5
to
4a29161
Compare
* Replace the BinaryHeap with PriorityQueue, which supports removals. * Refactor the wait list into a separate type to isolate the operations.
cloneable
force-pushed
the
queued-waker-removal-on-getconn-drop
branch
from
4a29161
to
dc78d2d
Compare
|
@cloneable, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when the task that holds the
GetConnfuture gets woken by anotherWaker, like whenGetConnis wrapped withtokio::time::timeoutand similar.Closes #215