-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding domain used for TLS hostname verification #289
Allow overriding domain used for TLS hostname verification #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for whipping this up, @rjobanp!
@blackbeam—hopefully this is something that other users of mysql_async
might find useful too. Would be a big help for us at @MaterializeInc!
9776af0
to
d78dfde
Compare
@blackbeam thank you for reviewing and merging my PRs into this repo and mysql-common! Do you plan to cut a new release for both crates soon? Thanks again! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mysql_async](https://github.com/blackbeam/mysql_async) | workspace.dependencies | minor | `0.33.0` -> `0.34.0` | --- ### Release Notes <details> <summary>blackbeam/mysql_async (mysql_async)</summary> ### [`v0.34.1`](https://github.com/blackbeam/mysql_async/releases/tag/v0.34.1) [Compare Source](https://github.com/blackbeam/mysql_async/compare/v0.34.0...v0.34.1) #### What's Changed - Fix imports for non-default features by [@​blackbeam](https://github.com/blackbeam) in [blackbeam/mysql_async#299 **Full Changelog**: blackbeam/mysql_async@v0.34.0...v0.34.1 ### [`v0.34.0`](https://github.com/blackbeam/mysql_async/releases/tag/v0.34.0) [Compare Source](https://github.com/blackbeam/mysql_async/compare/v0.33.0...v0.34.0) #### What's Changed - Use an explicit priority check by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#271 - Refactor pool creation in tests by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#268 - Implement Borrow<QueueId> for QueuedWaker by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#266 - Inline poll_new_conn_inner into only caller by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#267 - Make queue_id non-optional by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#273 - Drop unnecessary use of Pin by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#277 - Silence clippy warnings by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#276 - Always save the most recent waker by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#272 - Delete GetConnInner::take by [@​espindola](https://github.com/espindola) in [blackbeam/mysql_async#279 - fix skip_domain_validation usage when using rustls by [@​alekitto](https://github.com/alekitto) in [blackbeam/mysql_async#284 - annotate `Transaction` with `must_use` by [@​petrosagg](https://github.com/petrosagg) in [blackbeam/mysql_async#290 - Allow specifying root certs and Client Identity as bytes rather than via a file by [@​blackbeam](https://github.com/blackbeam) in [blackbeam/mysql_async#291 - Allow specifying root certs and Client Identity \[for native-tls] as bytes rather than via a file by [@​rjobanp](https://github.com/rjobanp) in [blackbeam/mysql_async#288 - Allow overriding domain used for TLS hostname verification by [@​blackbeam](https://github.com/blackbeam) in [blackbeam/mysql_async#292 - Allow overriding domain used for TLS hostname verification by [@​rjobanp](https://github.com/rjobanp) in [blackbeam/mysql_async#289 - Use DROP USER in test by [@​grooverdan](https://github.com/grooverdan) in [blackbeam/mysql_async#295 - proxy `mysql_common` features by [@​blackbeam](https://github.com/blackbeam) in [blackbeam/mysql_async#297 #### New Contributors - [@​espindola](https://github.com/espindola) made their first contribution in [blackbeam/mysql_async#271 - [@​alekitto](https://github.com/alekitto) made their first contribution in [blackbeam/mysql_async#284 - [@​petrosagg](https://github.com/petrosagg) made their first contribution in [blackbeam/mysql_async#290 - [@​rjobanp](https://github.com/rjobanp) made their first contribution in [blackbeam/mysql_async#288 - [@​grooverdan](https://github.com/grooverdan) made their first contribution in [blackbeam/mysql_async#295 **Full Changelog**: blackbeam/mysql_async@v0.33.0...v0.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on the first day of the month" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/get-convex/convex). GitOrigin-RevId: 6509626c78732e9f033417b4c3c47faab9a00e4b
Adds support for specifying an alternate domain name for TLS hostname verification, which is useful in a scenario where the mysql connection is being tunneled and the connection host and remote server host are different.
Thanks!