-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object filter ratio #2952
Add object filter ratio #2952
Conversation
Since you added a field to the model you will also need to add a migration class to the migrations folder. Should be able to go off of what's there, let me know if you have any questions on that. |
Where are you getting stuck running in the dev container? You should be able to run I use this config for local dev: cameras:
back:
ffmpeg:
inputs:
- path: /lab/frigate/airport.mp4
input_args: -re -stream_loop -1 -fflags +genpts |
@blakeblackshear Python isn't my primary programming language and I haven't developed any packages before, so was not familiar with the |
@blakeblackshear I got a |
@mathmaniac43 I believe you are supposed to make outside and then start the container. That's what I've always done |
- Accept `ratio` default - Rename `bounds` to `box` for consistency - Add migration for new field Issue: blakeblackshear#2948
- field migrations require default values - `clipped` referenced the wrong index for region, since it shifted - missed an inclusion of `ratio` for detections in `process_frames` - revert naming `o[2]` as `box` since it is out of scope! This has now been test-run against a video, so I believe the kinks are worked out. Issue: blakeblackshear#2948
Building outside the container is listed in the docs here: https://docs.frigate.video/contributing#core The command is now just |
- Ensure that defaults match between Event and migration script - Deconflict migration script number (from rebase) Issue: blakeblackshear#2948
@NickM-27 Makes sense, just fixed! |
Looks good to me 👍 |
@blakeblackshear Pinging to make sure this has not fallen off your radar. Thanks. |
Just busy with other things at the moment |
Per issue #2948 (take two, this time targeting the correct branch
release-0.11.0
)I was not able to figure out how to run frigate in a dev. container on a recorded video the way I wanted to for testing, but am open to doing so if I can get a bit of help/instruction.
I also did my best to maintain existing style/phrasing throughout, but feel free to make adjustments/requests if you think it should be improved.
Thanks!