-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow birdseye to be overridden at the camera level #3083
Allow birdseye to be overridden at the camera level #3083
Conversation
I think this is pretty simple, just not sure on the docs since the I created the separate |
@@ -775,6 +785,7 @@ def runtime_config(self) -> FrigateConfig: | |||
# Global config to propegate down to camera level | |||
global_config = config.dict( | |||
include={ | |||
"birdseye": ..., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you disable globally and then enable a single camera, does that enable Birdseye for the one camera?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With birdseye disabled globally, there is no option in the sidebar. If I bypass that then it still isn't enabled as the global check to add the converter["birdseye"] doesn't go through. Not sure what the best behavior would be; I could add a warning in the config if it is disabled globally but has camera enabled, or adapt those behaviors to consider the camera level as well, or perhaps it is good as is.
Might be a good idea to add some unit tests for the additional config parsing to make sure it handles things the way we expect. |
Yeah good idea, I think the two I added should cover the cases but let me know if I missed any 👍 |
Implementation of #2582