Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change-case/keys types #337

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix change-case/keys types #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/change-case/src/keys.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
import { describe, it, expect } from "vitest";
import { camelCase } from "./keys";
import * as changeCase from "./index.js";

const TEST_CASES: [unknown, number | undefined, unknown][] = [
type TestCase = [
unknown,
number | undefined,
unknown,
(changeCase.Options | changeCase.PascalCaseOptions)?,
];

const TEST_CASES: TestCase[] = [
[
{
first_name: "bob",
Expand Down
16 changes: 11 additions & 5 deletions packages/change-case/src/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import * as changeCase from "./index.js";
const isObject = (object: unknown) =>
object !== null && typeof object === "object";

function changeKeysFactory(
function changeKeysFactory<
Options extends changeCase.Options = changeCase.Options,
>(
changeCase: (input: string, options?: changeCase.Options) => string,
): (object: unknown, depth?: number) => unknown {
): (object: unknown, depth?: number, options?: Options) => unknown {
return function changeKeys(
object: unknown,
depth = 1,
options?: changeCase.Options,
options?: Options,
): unknown {
if (depth === 0 || !isObject(object)) return object;

Expand All @@ -32,14 +34,18 @@ function changeKeysFactory(
};
}

export const camelCase = changeKeysFactory(changeCase.camelCase);
export const camelCase = changeKeysFactory<changeCase.PascalCaseOptions>(
changeCase.camelCase,
);
export const capitalCase = changeKeysFactory(changeCase.capitalCase);
export const constantCase = changeKeysFactory(changeCase.constantCase);
export const dotCase = changeKeysFactory(changeCase.dotCase);
export const trainCase = changeKeysFactory(changeCase.trainCase);
export const noCase = changeKeysFactory(changeCase.noCase);
export const kebabCase = changeKeysFactory(changeCase.kebabCase);
export const pascalCase = changeKeysFactory(changeCase.pascalCase);
export const pascalCase = changeKeysFactory<changeCase.PascalCaseOptions>(
changeCase.pascalCase,
);
export const pathCase = changeKeysFactory(changeCase.pathCase);
export const sentenceCase = changeKeysFactory(changeCase.sentenceCase);
export const snakeCase = changeKeysFactory(changeCase.snakeCase);
Loading