Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atomWithEffectsFromRecoilValue effect onSet params #32

Conversation

barodeur
Copy link
Contributor

First of all, thanks for this library 🙏.

I noticed that the ~newValue and ~oldValue parameters of the onSet effect callback had the type Recoil.t<'value> instead of 'value when using the FromRecoilValue function.

@bloodyowl
Copy link
Owner

Hi! Thanks for your PR!

Indeed that seems like a mistake.

Can you add a small test for onSet so that we confirm there won't be any regressions?

@bloodyowl bloodyowl merged commit a74ac31 into bloodyowl:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants