Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: npm audit trivial fixes. #170

Merged
merged 1 commit into from
Apr 14, 2022
Merged

deps: npm audit trivial fixes. #170

merged 1 commit into from
Apr 14, 2022

Conversation

tzfx
Copy link
Contributor

@tzfx tzfx commented Apr 13, 2022

  • Ran npm audit fix and applied all trivial dependency updates.
  • Verified all tests still pass.
  • Slightly modified the husky precommit to use npx, which should allow lint-stage to run from the local repo without requiring a dev has lint-staged on their global path (which I totally didn't and got a precommit rejection when lint-staged didn't work).

@@ -56,7 +56,7 @@
"lodash": "4.17.21",
"luxon": "^1.27.0",
"method-override": "3.0",
"moment": "^2.24.0",
"moment": "^2.29.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that bunyan still requires this. Did a quick look at bunyan and it honestly looks the like repo may be effectively abandoned by the maintainer without giving direction to the community... It may be worthwhile for us to move to something like pino- https://github.com/pinojs/pino which is actively maintained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trentm/node-bunyan#335 (comment) ⬅️ Last "plan" to maintain was 2020, last overall commit was 15mo ago...

@tzfx tzfx requested a review from jrassa April 13, 2022 17:35
@jrassa jrassa merged commit 8dc9ecf into develop Apr 14, 2022
@tzfx tzfx deleted the deps/npm-audit branch April 15, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants