Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored regex validation #170

Merged
merged 2 commits into from
Aug 28, 2024
Merged

refactored regex validation #170

merged 2 commits into from
Aug 28, 2024

Conversation

VishnuSrivatsava
Copy link

Refactored the regex validation for models and controllers into guideHelpers.js
this will close the issue #169

erenfn
erenfn requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@erenfn erenfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change import statements to require:

SyntaxError: Cannot use import statement outside a module

backend/src/models/Popup.js Outdated Show resolved Hide resolved
backend/src/models/Banner.js Outdated Show resolved Hide resolved
@VishnuSrivatsava
Copy link
Author

@erenfn also are there any internship/job (remote) opportunities? Would love to work on some interesting issues.

@erenfn
Copy link
Contributor

erenfn commented Aug 28, 2024

@gorkem-bwl

@erenfn erenfn linked an issue Aug 28, 2024 that may be closed by this pull request
Change Color Regex Logic #169
Closed
@gorkem-bwl
Copy link
Contributor

@erenfn also are there any internship/job (remote) opportunities? Would love to work on some interesting issues.

Currently we don't, but will let you know once there is one. Until that time feel free to contribute to the repo. Thank you!

@erenfn erenfn merged commit 9a4d40d into bluewave-labs:develop Aug 28, 2024
1 check passed
@VishnuSrivatsava
Copy link
Author

@erenfn also are there any internship/job (remote) opportunities? Would love to work on some interesting issues.

Currently we don't, but will let you know once there is one. Until that time feel free to contribute to the repo. Thank you!

Thank you! Will contribute in my free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erenfn erenfn erenfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Color Regex Logic
3 participants
@VishnuSrivatsava @erenfn @gorkem-bwl