Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix panic when calling toString with radix #2863

Closed
wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Apr 23, 2023

This Pull Request fixes/closes #2717 and related to #2479

This was caused by an incorrect to digit conversion.

Here are two examples that always cause a panic. They have been added as a test in number/test.rs

(0.1600057092765239).toString(36)
(0.23046743672210102).toString(36)

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 23, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 23, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,591 94,591 0
Passed 73,191 73,191 0
Ignored 17,530 17,530 0
Failed 3,870 3,870 0
Panics 0 0 0
Conformance 77.38% 77.38% 0.00%

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2863 (d8f90e0) into main (93b52cd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
+ Coverage   50.92%   50.97%   +0.04%     
==========================================
  Files         419      419              
  Lines       41783    41824      +41     
==========================================
+ Hits        21280    21321      +41     
  Misses      20503    20503              
Impacted Files Coverage Δ
boa_engine/src/builtins/number/mod.rs 85.56% <100.00%> (+3.96%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nekevss
Copy link
Member

nekevss commented Apr 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 23, 2023
This Pull Request fixes/closes #2717 and related to #2479

This was caused by an incorrect to digit conversion.

Here are two examples that always cause a panic. They have been added as a test in `number/test.rs`
```js
(0.1600057092765239).toString(36)
(0.23046743672210102).toString(36)
```
@bors
Copy link

bors bot commented Apr 23, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix panic when calling toString with radix [Merged by Bors] - Fix panic when calling toString with radix Apr 23, 2023
@bors bors bot closed this Apr 23, 2023
@bors bors bot deleted the fix/issue-2717 branch April 23, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: character was not a valid digit
3 participants