This repository has been archived by the owner on Sep 3, 2019. It is now read-only.
25 vote set threshold #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT1943
reviewed
Jun 17, 2019
| @@ -16,7 +16,7 @@ contract EventFactory is NRC223Receiver { | |||
| uint amount; | |||
| } | |||
|
|
|||
| uint16 private constant VERSION = 5; | |||
| uint16 private constant VERSION = 6; | |||
There was a problem hiding this comment.
can we create a branch called version-6 and branch off all these changes into that branch, and merge deploy all together when everything is done.
There was a problem hiding this comment.
what other changes need to go into this version?
| @@ -16,7 +16,7 @@ contract EventFactory is NRC223Receiver { | |||
| uint amount; | |||
| } | |||
|
|
|||
| uint16 private constant VERSION = 5; | |||
| uint16 private constant VERSION = 6; | |||
There was a problem hiding this comment.
can we create a branch called version-6 and branch off all these changes into that branch, and merge deploy all together when everything is done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25