This repository has been archived by the owner on Sep 3, 2019. It is now read-only.
fixHighLvlTryCatch #206
Merged
fixHighLvlTryCatch #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalintukan
approved these changes
Nov 9, 2018
| @@ -436,23 +436,24 @@ export default class AccountController extends IController { | |||
| }); | |||
| } | |||
|
|
|||
| private handleMessage = (request: any, _: chrome.runtime.MessageSender, sendResponse: (response: any) => void) => { | |||
| private handleMessage = async (request: any, _: chrome.runtime.MessageSender, | |||
There was a problem hiding this comment.
params should be indented with 2 spaces if separating them on diff lines:
myFunc = async (
param1,
param2,
) => {
}
…c we are setting version in manifest.json
soshochang
force-pushed
the
fixHighLvlTryCatch
branch
from
724c539
to
72c5251
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-when insightAPI is down we were still not displaying an error dialog, but rather the loading screen was still hanging. We had previously added a high lvl try catch code to handle this error case, but it did not work, this has now been fixed.