-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ldap support in docker image #205
Conversation
Include ldap support in docker image
Hi, looks OK. Tests are successful. I would suggest:
Cheers, |
Will do, thanks. I've been sidetracked this week with some unrelated database issues that I need to track down. Once I get that figured out (hopefully tonight) I'll finish this up. In addition I want to fully test that ldap is working with only that package being installed before I undraft it. Last I left it, I was getting an error binding, but I'm pretty sure that's just my config. |
I should have some time to work on this over the weekend. What kind of tests are you looking for? It should be easy enough to test that when an ldap map is configured it doesn't give the error that ldap isn't supported. Doing anything beyond that would require setting up and configuring an ldap server for the test. |
@bokysan I added some integration tests, but I'm not sure that they're actually meaningful. When I run them locally, via I'd be happy to update documentation if you think there is something meaningful to add, but this is just enabling a standard type of map in postfix. There's no config needed to enable support for them and it would be better if users went to postfix's documentation on how to use ldap maps. |
You can semi ignore that previous comment, I rewrote the ldap tests to use |
@bokysan can we get this merged in soon? |
Yeah, missed it. There we go. I'll test it out a bit and make a release this week. |
Fixes #204
Includes the
postfix-ldap
package in both debian and alpine docker images.